Changeset 1e48810b116eeedf5c9eab987e322a9404ee39cd

Timestamp:

06/03/09 19:39:47 (4 years ago)

Author:

Armin Burgmeier <armin@…>

Parents:

2891196639b3fb29ce483e091f557d9ae093276d

Children:

b9f0eda66558c4d1215da5ff56da6466557ea331

git-committer:

Armin Burgmeier <armin@arbur.net> / 2009-06-03T19:39:47Z+0200

Message:

Don't use localized action names, so Gobby starts on Japanese systems

2009-06-03 Armin Burgmeier <armin@…>

• code/core/header.cpp: Replace localized section string by a numerical ID for the action names of the various language sections, to prevent a crash when starting Gobby on a Japanese system. Based on a patch by Takahiro Sunaga.

Files:

• ChangeLog (modified) (1 diff)
• code/core/header.cpp (modified) (2 diffs)

ChangeLog

@@ +1 @@
+2009-06-03  Armin Burgmeier  <armin@arbur.net>
+
+        * code/core/header.cpp: Replace localized section string by a
+        numerical ID for the action names of the various language sections, to
+        prevent a crash when starting Gobby on a Japanese system. Based on a
+        patch by Takahiro Sunaga.
+
 2009-05-26  Armin Burgmeier  <armin@arbur.net>
 

code/core/header.cpp

@@ -356 +356 @@
         group_view->add(action_view_highlight_mode);
         group_view->add(action_view_highlight_none);
+        
+        unsigned int language_menu_counter = 0;
         for(LanguageMap::const_iterator iter =
                 action_view_highlight_languages.begin();
@@ -361 +363 @@
             ++ iter)
         {
+                // We cannot use iter->first for the action name, since this
+                // is a localized string.
                 Glib::ustring section_action_name =
-                        "ViewHighlightModeSection_" + iter->first;
+                        Glib::ustring::compose("ViewHighlightModeSection_%1",
+                                language_menu_counter);
+                ++language_menu_counter;
+
                 Glib::ustring section_action_xml =
                         Glib::Markup::escape_text(section_action_name);