Changeset afd454ec7bc71e7259cfcffc87e8fc831fe91a0c

Timestamp:

17/10/08 02:55:46 (5 years ago)

Author:

Armin Burgmeier <armin@…>

Parents:

58965b7960d54ff675c730805c4b87f9535d43be

Children:

ceb01ffcf55b2cb6b0afaec921a6b28cb73d5e2d

git-committer:

Armin Burgmeier <armin@arbur.net> / 2008-10-17T02:55:46Z+0200

Message:

Show a senseful error message when a synchronization failed

2008-10-16 Armin Burgmeier <armin@…>

• code/commands/browser-commands.cpp (on_synchronization_failed): Remove the entry from the session map directly instead of waiting for session closure, otherwise the error message is overwritten with a useless (and incorrent) 'The connection to the publisher has been lost' one.

Files:

• ChangeLog (modified) (1 diff)
• code/commands/browser-commands.cpp (modified) (1 diff)

ChangeLog

@@ +1 @@
+2008-10-16  Armin Burgmeier  <armin@arbur.net>
+
+        * code/commands/browser-commands.cpp (on_synchronization_failed):
+        Remove the entry from the session map directly instead of waiting for
+        session closure, otherwise the error message is overwritten with a
+        useless (and incorrent) 'The connection to the publisher has been
+        lost' one.
+
 2008-10-15  Armin Burgmeier  <armin@arbur.net>
 

code/commands/browser-commands.cpp

@@ -395 +395 @@
                 gtk_text_buffer_set_modified(
                         GTK_TEXT_BUFFER(window->get_text_buffer()), FALSE);
+
+                // Don't wait until the session is closed because of this,
+                // since this would also cause a connection notify,
+                // overwriting the error message with a useless one.
+                m_session_map.erase(iter);
         }
 }