Ticket #143 (closed enhancement: fixed)

Opened 7 years ago

Last modified 6 years ago

Broadcast document removals

Reported by: phil Owned by: phil
Priority: normal Milestone: Sobby 0.4.0
Component: Sobby Version: 0.4.0
Severity: normal Keywords:
Cc: Launchpad Bug:

Description

Document removals in Sobby sessions should be broadcasted just like creations.

Change History

Changed 7 years ago by phil

  • status changed from new to assigned
  • owner changed from armin to phil

Changed 7 years ago by phil

  • status changed from assigned to closed
  • resolution set to fixed

Changed 7 years ago by phil

  • status changed from closed to reopened
  • resolution fixed deleted

I did just emit a server message in Sobby, so this is not localised. Is this ok, or do I need to put the message string into Gobby?

Changed 7 years ago by armin

It should be completely analogous(?) to the "document has been inserted message". AFAIK does obby::chat write a message to the chat in that case (on the client side, which is therefore localised).

Changed 7 years ago by phil

Armin, could you implement a handler into Gobby for this? (For the message to be localised.)

Changed 7 years ago by armin

What is the problem with implementing this in obby::chat, as with document creation announcements?

Changed 7 years ago by phil

There is none, I think. (:

Changed 7 years ago by armin

  • status changed from reopened to closed
  • resolution set to fixed

I just wondered because you mentioned Gobby already twice. Patch committed for obby.

Changed 7 years ago by rog dwayne

  • status changed from closed to reopened
  • resolution fixed deleted

Changed 6 years ago by phil

  • status changed from reopened to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.