Ticket #211 (closed enhancement: fixed)

Opened 7 years ago

Last modified 4 years ago

Reset Marks

Reported by: deimeke@… Owned by: armin
Priority: normal Milestone: Gobby 0.4.93
Component: Gobby Version:
Severity: normal Keywords:
Cc: Launchpad Bug:

Description

Please give users the possibility to reset the marks of an edited document.

Change History

  Changed 7 years ago by phil

Why?

  Changed 7 years ago by deimeke@…

In a long edtiing session with lots of changes any document becomes almost unreadable because of the different marks.

follow-up: ↓ 4   Changed 7 years ago by phil

Then your colours are flawed.

in reply to: ↑ 3 ; follow-up: ↓ 5   Changed 7 years ago by deimeke@…

That is not the point.

Current changes are important. Changes that are older than one hour aren't. So the possibilty to reset the marks would hekp.

in reply to: ↑ 4   Changed 6 years ago by anonymous

Replying to [comment:4 deimeke@googlemail.com]:
> Current changes are important. Changes that are older than one hour aren't. So the possibilty to reset the marks would help.

loading your files in a new sessions does exactly that, though it's needed to close the server what actually is not useful in every case.

on the other hand in light there is no undo functionality the colour history becomes useless after time.

  Changed 4 years ago by graf@…

The original poster is absolutely right:

Even with just 3 people editing a document, the problem arises in passages that get edited a lot. After a while you have more change markers than syntax highlighting. The other point is: it is definately important to mark changes, but (in our case) after some days of editing a document, the document gets very colorful and the change markers are just no more interesting.

Users want to focus on syntax highlighting and content and thus want to remove all other distractions like change markers once in a while. - This is by the way the feature that I heard most often in the team from almost _every_ new gobby user in our team.

Restarting the server is a workaround but not a satisfying procedure.

Please give us a "clear change markers" option.

  Changed 4 years ago by erich@…

IMHO it would make sense to be able to purge (or at least hide, client side? - or archive) markers

  • by time (e.g. older than 24h)
  • by number of edits (e.g. only show last 500 edits)

Thank you.

  Changed 4 years ago by armin

It is not so trivial to keep track of either one, unfortunately.

So I am thinking about an option to clear colors right after subscription (so one only sees color for stuff that is added after one joined). This also means that in order to clear user colors one can resubscribe to the document (note that Undo history is not even lost when doing so). It's wasteful however, so if we can find a good place where to put a possibility to clear the user colors into the GUI (menubar/toolbar? context menu?).

Hm. Context menu might be an interesting possibility actually because it also allows to only remove user colors in a given range of the text, say the user selection (default to clear all in case nothing is selected).

  Changed 4 years ago by Locked

I'd try to keep it simple stupid and put it into the menu bar: View (or Edit) > Clear changemarks (in the current document)

I think that would satisfy most users' needs. And as it is user triggered only, hardly anyone could complain about "magically" disappearing marks (like it could be if marks disappear after x edits/hours).

If a more sophisticated mechanism is desired, users could still open a feature request.

  Changed 4 years ago by armin

Note that any removal of user coloring will be for the local user only in any case.

  Changed 4 years ago by Locked

Note that any removal of user coloring will be for the local user only in any case.

Yes of course! I'd never intended to change the display of other editors with this action.

  Changed 4 years ago by armin

  • milestone set to Gobby 0.4.93

Oh, sorry, I misread your post the first time. Sorry.

Yeah, I also prefer removing them only when the user explicitly requests so.

Let's put this on the agenda for 0.4.93.

  Changed 4 years ago by armin

  • status changed from new to closed
  • resolution set to fixed

I implemented this for Gobby 0.4.93. There is a menu item in the view menu and a Shift+Ctrl+C shortcut.

Note: See TracTickets for help on using tickets.