Ticket #276 (new enhancement)

Opened 6 years ago

Last modified 3 years ago

Spellchecking in Gobby

Reported by: bruno.patri@… Owned by: armin
Priority: normal Milestone:
Component: Gobby Version:
Severity: normal Keywords:
Cc: Launchpad Bug:

Description (last modified by Locked) (diff)

Hi, missing spellchecking was also a (minor) issue raised against gobby here sometimes.

Attachments

spellchecking.patch (14.0 kB) - added by simedw 3 years ago.
Patch for enable gtk-spellchecking

Change History

  Changed 6 years ago by imjustmatthew

Spell checking is really important for writing large collaborative reports using LaTeX, right now we are having to export the text to another editor to do spell checking - a painful process for a nearly hundred page document. Now that Gobby is more or less stable this is a feature I would strongly encourage you guys to push to the forefront of future releases.

  Changed 5 years ago by anonymous

I agree. I really miss spellchecking.

  Changed 4 years ago by jansimon

that would be really good !

+1 !!

  Changed 4 years ago by phaer

I totally agree. This is a must-have feature for anyone who does more than coding. :) +1

  Changed 4 years ago by ubuntu@…

I, too, miss spellchecking.

  Changed 4 years ago by phil

Hooked it up with gtkspell in [69a0b4d86fb564b8fe9832307450b7777ff470c3]. No language choosing possible yet, though. And it's deactivated by default and needs activation by passing --with-gtkspell to configure.

in reply to: ↑ description   Changed 4 years ago by Locked

  • description modified (diff)

Replying to bruno.patri@…:

hello, We are using Gobby for collaborative translations, it would be nice if Gobby could use aspell for spell checking. Sorry if it's not the right place for that.

Changed 3 years ago by simedw

Patch for enable gtk-spellchecking

in reply to: ↑ description   Changed 3 years ago by simedw

I have attached a patch to enable gtk-spell checking in the latest gobby git (0.5 branch). You can enable it by default in preferences and on a document by document basis.

I don't know if gtkspell is the best spell checker around but it was very easy to add :) And I hope this is the right place to attach patches, when I asked in the irc room I couldn't get any response...

  Changed 3 years ago by armin

Thanks for the patch. A few comments:

  • There should be a configure check to optionally disable gtkspell.
  • The shortcut F7 is already in use by GtkTextView?, so I'd prefer if we could choose another one. I think F2 is available, or maybe F7 plus some modifier.
  • Why is the GError* a member variable in TextSessionView??
  • There seems to be one 'l' too much in m_btn_spelllcheck_enabled :)
  • get_/set_ functions should be symmetric, so please rename set_spellcheck to set_spellcheck_enabled. Also please name function parameters in headers.
  • I don't like popup dialogs, and especially not modal ones. If spellcheck initialization fails the error message should go to the status bar.

Can you take care of these things?

  Changed 3 years ago by simedw

Sure, I'll try to fix and resubmit a patch in the next couple of days.

  Changed 3 years ago by armin

Let me know if you encounter any problems.

Note: See TracTickets for help on using tickets.