Ticket #397 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

gobby enhancement to save other encodings.

Reported by: takao.fujiwara@… Owned by: armin
Priority: normal Milestone:
Component: Gobby Version:
Severity: normal Keywords:
Cc: takao.fujiwara@… Launchpad Bug:

Description

The current gobby has the hard-coded encoding list "UTF-8", "ISO-8859-1", "ISO-8859-15", "UTF-7", "UTF-16", "UCS-2" and "UCS-4". The encoding is useful for some locales but not other ones.

I'd like to enhance the encoding.
#1. Can save the file with the current encoding.
#2. Can define the encoding list by locale.

Regarding #1, g_get_charset() can get the current encoding so if users launch gobby on none UTF-8 locale, they can save the file content with their encoding.

Regarding #2, if the list can be exported to .po files, the list can be defined in .po files.

I'm attaching the patch for 0.4.6
Unfortunately I haven't succeeded to build the latest gobby since it depends on libinfinity.

Attachments

gobby-xx-g11n-encoding.diff (1.7 kB) - added by takao.fujiwara@… 5 years ago.
Patch for src/encoding.cpp
gobby-xx-ja-po.diff (1.9 kB) - added by takao.fujiwara@… 4 years ago.
Patch for po/ja.po

Change History

Changed 5 years ago by takao.fujiwara@…

Patch for src/encoding.cpp

Changed 5 years ago by armin

  • status changed from new to closed
  • resolution set to fixed

Thanks. I committed the patch after having it C++ified a bit.

For Gobby 0.4.90, there currently is no encoding list for file selection yet. But I marked the 8bit encoding that is tried when autodetecting a file's encoding for translation with this commit.

Changed 4 years ago by takao.fujiwara@…

Patch for po/ja.po

Changed 4 years ago by anonymous

Thanks for committing the patches. I also attached the patch of ja.po to add the encodings and gobby.desktop file.

I filed #403 for the left bugs.

Changed 4 years ago by armin

I committed the translation update. Thanks!

Note: See TracTickets for help on using tickets.