Ticket #469 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Gobby doesn't build with glibmm 2.16

Reported by: Nicolas Owned by: armin
Priority: normal Milestone:
Component: Gobby Version: 0.4.92
Severity: normal Keywords:
Cc: Launchpad Bug:

Description

Compiling gobby from source (v0.4.92-53-g556c3ca) in Ubuntu Hardy with glibmm 2.16.4, I get the following error:

In file included from task-open-multiple.cpp:20:
../../../code/commands/file-tasks/task-open-multiple.hpp:43: error: 'Gio' was not declared in this scope
../../../code/commands/file-tasks/task-open-multiple.hpp:43: error: template argument 1 is invalid
../../../code/commands/file-tasks/task-open-multiple.hpp:46: error: 'Gio' was not declared in this scope
../../../code/commands/file-tasks/task-open-multiple.hpp:46: error: template argument 1 is invalid

This fixes it:

diff --git a/code/commands/file-tasks/task-open-multiple.hpp b/code/commands/file-tasks/task-open-multiple.hpp
index 92f5a6e..eadf24a 100644
--- a/code/commands/file-tasks/task-open-multiple.hpp
+++ b/code/commands/file-tasks/task-open-multiple.hpp
@@ -19,6 +19,7 @@
 #ifndef _GOBBY_FILE_TASK_OPEN_MULTIPLE_HPP_
 #define _GOBBY_FILE_TASK_OPEN_MULTIPLE_HPP_

+#include <giomm/file.h>
 #include "commands/file-commands.hpp"

 #include <vector>

Change History

Changed 4 years ago by ubergeek42

I can confirm that this is an issue(gentoo x86_64, glibmm-2.16.4), and that the proposed patch fixes it.

Changed 4 years ago by armin

  • status changed from new to closed
  • resolution set to fixed

I have applied the fix. Thanks for the patch!

Note: See TracTickets for help on using tickets.